fix: route iOS write tags to correct EXIF dictionaries#23
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11. iOS
writewas putting all tags intokCGImagePropertyExifDictionary, causing TIFF tags (Make,Model,Software,DateTime) and most GPS tags (GPSDOP,GPSImgDirection,GPSImgDirectionRef) to be silently dropped.Tags are now routed to the correct sub-dictionary:
kCGImagePropertyTIFFDictionarykCGImagePropertyGPSDictionary(generic, not just 5 hardcoded)kCGImagePropertyExifDictionaryAlso adds
HostComputertoExifTagstype.Type of Change
Test Plan
Took photo in example app, wrote tags (Make, Model, Software, DateTime, GPSDOP, GPSImgDirection, GPSImgDirectionRef), saved to media library, read back — all tags preserved.
Checklist